Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esplora): include previous TxOuts for fee calculation #1

Open
wants to merge 1 commit into
base: bitcoindevkit-fresheyes-master-1308
Choose a base branch
from

Conversation

adamjonas
Copy link
Owner

Description

Partially implements bitcoindevkit#1265.

The previous TxOut for transactions received from an external wallet are added as floating TxOuts to TxGraph to allow for fee calculation.

Notes to the reviewers

Currently only the esplora portion of bitcoindevkit#1265 has been implemented.
The electrum portion will potentially be done in a new PR, as discussed on the 1/30/24 Lib call.

Checklists

To Do:

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

The previous `TxOut` for transactions received from an external
wallet are added as floating `TxOut`s to `TxGraph` to allow for
fee calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants